Open
Conversation
- fixing condition for triggering of workflow, now triggers once per release - github runner updated to ubuntu=22.04 since 20.04 will be deprecated in April 25 - added github logs to assist debugging
Thanks to @covracer for the recommended fix here https://stackoverflow.com/questions/54887301/how-can-i-use-git-repos-as-dependencies-for-my-pypi-package
at this stage enables dynamic input from setup.py for python -m build https://build.pypa.io/en/stable/index.html
…l and normal wheel for Github actions
Collaborator
Author
|
Pending a discussion re #323 this is ready for review, thanks! |
Collaborator
Author
|
I'd put this on hold for until I can look into the multi platform build without the tvtk dependencies - also the "publish" test should be automatically skipped. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled, also includes update to pyproject.toml for potentially replacing the setup.py build process - tested with act and github action runners.
Issue being addressed is the mayavi direct dependency for pypi uploads - https://stackoverflow.com/questions/54887301/how-can-i-use-git-repos-as-dependencies-for-my-pypi-package