Skip to content

fix(helm): pod security context#29

Merged
varonix0 merged 3 commits intomainfrom
daniel/deployment-fix
Dec 4, 2025
Merged

fix(helm): pod security context#29
varonix0 merged 3 commits intomainfrom
daniel/deployment-fix

Conversation

@varonix0
Copy link
Copy Markdown
Member

@varonix0 varonix0 commented Dec 4, 2025

Fixed missing configuration for pod security context caused by the helm generation script. It now correctly infers from the manager (/config/manager/manager.yaml)

@varonix0 varonix0 self-assigned this Dec 4, 2025
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Dec 4, 2025

Greptile Overview

Greptile Summary

Fixed missing seccompProfile configuration in pod security context by removing hardcoded workaround and allowing helmify to properly infer the complete security context from /config/manager/manager.yaml.

The previous implementation had a workaround in the generation script that hardcoded only runAsNonRoot: true, inadvertently dropping the seccompProfile setting. This fix removes that workaround, allowing the Helm chart to correctly template the full pod security context including both runAsNonRoot and seccompProfile fields.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes correctly fix a configuration bug by removing problematic hardcoded logic and properly inferring security settings from the canonical source. All changes are consistent, the version bump is appropriate, and the implementation properly maintains security best practices.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
scripts/generate-helm.sh 5/5 Removed hardcoded podSecurityContext replacement logic, now correctly infers from manager.yaml via helmify
helm-charts/secrets-operator/values.yaml 5/5 Added podSecurityContext with runAsNonRoot and seccompProfile from manager.yaml, updated version to v0.10.14
helm-charts/secrets-operator/templates/deployment.yaml 5/5 Changed from hardcoded securityContext to templated .Values.controllerManager.podSecurityContext with proper YAML formatting
helm-charts/secrets-operator/Chart.yaml 5/5 Bumped chart version and appVersion from v0.10.13 to v0.10.14

Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@varonix0 varonix0 merged commit ea528f5 into main Dec 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants