ci(cxx-python): remove explicit CMAKE_CXX_STANDARD #1430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already set in our CMakeLists.txt. Suggested-by: Niels Dekker <[email protected]>
Member
Author
|
Closes #1427 |
N-Dekker
reviewed
Jul 22, 2025
| with: | ||
| itk-module-deps: '[email protected]' | ||
| ctest-options: '-E itkPipelineTest' | ||
| itk-cmake-options: '-DCMAKE_CXX_STANDARD:BOOL=20' |
Contributor
There was a problem hiding this comment.
Maybe this line was specifically meant to set the CXX_STANDARD for ITK (rather than ITK-Wasm)...? Because ITK has C++17 (rather than C++20) by default. If that's the case, only the BOOL may be buggy 🤷
Member
Author
|
Superceded by #1431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already set in our CMakeLists.txt.
Suggested-by: Niels Dekker [email protected]