Skip to content

ci(cxx-python): remove explicit CMAKE_CXX_STANDARD #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thewtex wants to merge 1 commit into from
Closed

ci(cxx-python): remove explicit CMAKE_CXX_STANDARD #1430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/cxx-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
with:
itk-module-deps: '[email protected]'
ctest-options: '-E itkPipelineTest'
itk-cmake-options: '-DCMAKE_CXX_STANDARD:BOOL=20'
Copy link
Contributor

@N-Dekker N-Dekker Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this line was specifically meant to set the CXX_STANDARD for ITK (rather than ITK-Wasm)...? Because ITK has C++17 (rather than C++20) by default. If that's the case, only the BOOL may be buggy 🤷

Copy link
Member Author

@thewtex thewtex Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!


#python-build-workflow:
## itk-wasm branch
Expand Down
Loading