Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Closes gh-1913

Add special-casing for empty mask in the implementation of tensor.place, which is used by usm_ndarray.__setitem__ as well.

Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Dec 2, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Dec 2, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_283 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.671% (+0.003%) from 87.668%
when pulling 2a643dd on fix-1913-empty-boolean-mask
into 4a94ef9 on master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 631d4c3 into master Dec 2, 2024
49 of 51 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-1913-empty-boolean-mask branch December 2, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dpctl raises exception with empty boolean array passed to __setitem__()

3 participants