Skip to content

Fix 1913 empty boolean mask #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix 1913 empty boolean mask #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd0d5e
Fix gh-1913
oleksandr-pavlyk Dec 2, 2024
2a643dd
Add tests for setitem/getitem for boolean indexing with empty mask
oleksandr-pavlyk Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dpctl/tensor/_copy_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,8 @@ def _place_impl(ary, ary_mask, vals, axis=0):
else:
rhs = dpt.astype(vals, ary.dtype)
rhs = dpt.broadcast_to(rhs, expected_vals_shape)
if mask_nelems == 0:
return
dep_ev = _manager.submitted_events
hev, pl_ev = ti._place(
dst=ary,
Expand Down
25 changes: 25 additions & 0 deletions dpctl/tests/test_usm_ndarray_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,31 @@ def test_boolean_indexing_validation():
x[ii[0, :]]


def test_boolean_indexing_getitem_empty_mask():
get_queue_or_skip()
x = dpt.ones((2, 3, 4), dtype="i4")
ii = dpt.ones((0,), dtype="?")
assert x[ii].size == 0
ii1 = dpt.ones((0, 3), dtype="?")
assert x[ii1].size == 0
ii2 = dpt.ones((0, 3, 4), dtype="?")
assert x[ii2].size == 0


def test_boolean_indexing_setitem_empty_mask():
get_queue_or_skip()
x = dpt.ones((2, 3, 4), dtype="i4")
ii = dpt.ones((0,), dtype="?")
x[ii] = 0
assert dpt.all(x == 1)
ii1 = dpt.ones((0, 3), dtype="?")
x[ii1] = 0
assert dpt.all(x == 1)
ii2 = dpt.ones((0, 3, 4), dtype="?")
x[ii2] = 0
assert dpt.all(x == 1)


def test_integer_indexing_1d():
get_queue_or_skip()
x = dpt.arange(10, dtype="i4")
Expand Down
Loading