Skip to content

update dpnp.result_type tests #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2024
Merged

update dpnp.result_type tests #2121

merged 4 commits into from
Oct 25, 2024

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Oct 23, 2024 •
edited
Loading

This PR updates tests for dpnp.result_type to align with recent changes in IntelPython/dpctl#1877

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the update-result_dtype branch from c614af9 to 0ec5f55 Compare October 23, 2024 16:09
@vtavana vtavana marked this pull request as ready for review October 24, 2024 16:11
antonwolfy
antonwolfy approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit e236ad9 into master Oct 25, 2024
45 of 46 checks passed
@vtavana vtavana deleted the update-result_dtype branch October 25, 2024 01:58
github-actions bot added a commit that referenced this pull request Oct 25, 2024
@github-actions
update dpnp.result_type tests (#2121)
a4de500 
* update dpnp.result_type tests

* Update tests/third_party/cupy/test_type_routines.py

Co-authored-by: Anton <[email protected]>

---------

Co-authored-by: Anton <[email protected]> e236ad9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana @antonwolfy