Do not use bash as default shell on Windows in Upload job #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vlad-perevezentsev
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
LGTM!
Thank you @antonwolfy for the timely implementation of this solution
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploadjob has been failing since version ofconda-incubator/setup-minicondawas bumped up to3.1.0.It seems
mamba installdoesn't properly work on Windows if the default job's shell is specified asbash -el {0}.Since it doesn't look proper to use
bash -el {0}as the Windows default shell, this PR proposes to remove that and to rely on default shell setting for a job.