Skip to content

Use hasattr instead of getattr in checks for convert_item call #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

Use hasattr instead of getattr in checks for convert_item call #2467

merged 3 commits into from
Jun 3, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 2, 2025 •
edited
Loading

The PR improves tests logic to replace unnecessary getattr with hasattr call to check an item interface.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Jun 2, 2025
ndgrigorian
ndgrigorian approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev0=py312h852cfe9_5 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@antonwolfy antonwolfy added this to the 0.18.0 release milestone Jun 3, 2025
@ndgrigorian ndgrigorian self-requested a review June 3, 2025 00:52
@antonwolfy antonwolfy merged commit 667fe3e into master Jun 3, 2025
66 of 67 checks passed
@antonwolfy antonwolfy deleted the improve-convert-item-in-tests branch June 3, 2025 16:30
antonwolfy added a commit that referenced this pull request Jun 3, 2025
@antonwolfy
Use hasattr instead of getattr in checks for convert_item call (#…
3155396 
…2467)

The PR improves tests logic to replace unnecessary `getattr` with
`hasattr` call to check an item interface.
@antonwolfy antonwolfy mentioned this pull request Jun 3, 2025
Merged
7 tasks
github-actions bot added a commit that referenced this pull request Jun 3, 2025
@github-actions
Use hasattr instead of getattr in checks for convert_item call (#…
5f2dc85 
…2467)

The PR improves tests logic to replace unnecessary `getattr` with
`hasattr` call to check an item interface. 667fe3e
github-actions bot added a commit that referenced this pull request Jun 3, 2025
@github-actions
Backprt gh-2467 493d6c6
01ecba0
antonwolfy added a commit that referenced this pull request Jun 3, 2025
@antonwolfy
Backprt gh-2467 (#2468)
fc8174f 
This PR backports of #2467 from development branch to
`maintenance/0.18.x`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.18.0 release

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @ndgrigorian