Skip to content

Use hasattr instead of getattr in checks for convert_item call #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025
Merged

Use hasattr instead of getattr in checks for convert_item call #2467

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65aa671
Use hasattr() instead of getattr() in convert_item
antonwolfy Jun 2, 2025
e8462b4
Add a note to changelog
antonwolfy Jun 3, 2025
9612356
Merge branch 'master' into improve-convert-item-in-tests
antonwolfy Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dpnp/dpnp_utils/dpnp_algo_utils.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ cdef ERROR_PREFIX = "DPNP error:"


def convert_item(item):
if getattr(item, "__sycl_usm_array_interface__", False):
if hasattr(item, "__sycl_usm_array_interface__"):
item_converted = dpnp.asnumpy(item)
elif getattr(item, "__array_interface__", False): # detect if it is a container (TODO any better way?)
elif hasattr(item, "__array_interface__"): # detect if it is a container (TODO any better way?)
mod_name = getattr(item, "__module__", 'none')
if (mod_name != 'numpy'):
item_converted = dpnp.asnumpy(item)
Expand Down
Loading