Update math tests to specify a proper tolerance #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_16 ran successfully. |
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
AlexanderKalistratov,
ndgrigorian,
vlad-perevezentsev and
vtavana
as code owners
vtavana
approved these changes
Jun 17, 2025
github-actions bot
added a commit
that referenced
this pull request
Jun 18, 2025
The PR updates third party tests for hyperbolic and trigonometric elementwise functions to specify correct tolerance for float16 data type (to set `atol=1e-3`) and to keep `atol=1e-5` for other dtypes. 7c2c8c2
antonwolfy
added a commit
that referenced
this pull request
Jun 20, 2025
The PR updates third party tests for hyperbolic and trigonometric elementwise functions to specify correct tolerance for float16 data type (to set `atol=1e-3`) and to keep `atol=1e-5` for other dtypes.
antonwolfy
added a commit
that referenced
this pull request
Jun 20, 2025
antonwolfy
added a commit
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates third party tests for hyperbolic and trigonometric elementwise functions to specify correct tolerance for float16 data type (to set
atol=1e-3) and to keepatol=1e-5for other dtypes.