Skip to content

Backport gh-2483 #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

Backport gh-2483 #2493

merged 2 commits into from
Jun 20, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 20, 2025 •
edited
Loading

This PR backports of #2483 from development branch to maintenance/0.18.x.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy
Update math tests to specify a proper tolerance (#2483)
8a4a63b 
The PR updates third party tests for hyperbolic and trigonometric
elementwise functions to specify correct tolerance for float16 data type
(to set `atol=1e-3`) and to keep `atol=1e-5` for other dtypes.
@antonwolfy antonwolfy added this to the 0.18.1 release milestone Jun 20, 2025
@antonwolfy antonwolfy self-assigned this Jun 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0=py312h852cfe9_5 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@antonwolfy antonwolfy merged commit 93fd1fb into maintenance/0.18.x Jun 20, 2025
69 of 81 checks passed
@antonwolfy antonwolfy deleted the backport-gh-2483-2 branch June 20, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.18.1 release

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @vtavana