Skip to content

Backport gh-2483 #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Backport gh-2483 #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a4a63b
Update math tests to specify a proper tolerance (#2483)
antonwolfy Jun 18, 2025
b61af92
Merge branch 'maintenance/0.18.x' into backport-gh-2483-2
antonwolfy Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions dpnp/tests/third_party/cupy/math_tests/test_hyperbolic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
import unittest

import numpy

from dpnp.tests.helper import has_support_aspect64
from dpnp.tests.third_party.cupy import testing


class TestHyperbolic(unittest.TestCase):

@testing.for_all_dtypes()
@testing.numpy_cupy_allclose(atol=1e-5, type_check=has_support_aspect64())
@testing.numpy_cupy_allclose(
atol={numpy.float16: 1e-3, "default": 1e-5},
type_check=has_support_aspect64(),
)
def check_unary(self, name, xp, dtype):
a = testing.shaped_arange((2, 3), xp, dtype)
return getattr(xp, name)(a)

@testing.for_dtypes(["e", "f", "d"])
@testing.numpy_cupy_allclose(atol=1e-5)
@testing.numpy_cupy_allclose(atol={numpy.float16: 1e-3, "default": 1e-5})
def check_unary_unit(self, name, xp, dtype):
a = xp.array([0.2, 0.4, 0.6, 0.8], dtype=dtype)
return getattr(xp, name)(a)
Expand All @@ -31,7 +36,7 @@ def test_arcsinh(self):
self.check_unary("arcsinh")

@testing.for_dtypes(["e", "f", "d"])
@testing.numpy_cupy_allclose(atol=1e-5)
@testing.numpy_cupy_allclose(atol={numpy.float16: 1e-3, "default": 1e-5})
def test_arccosh(self, xp, dtype):
a = xp.array([1, 2, 3], dtype=dtype)
return xp.arccosh(a)
Expand Down
3 changes: 2 additions & 1 deletion dpnp/tests/third_party/cupy/math_tests/test_trigonometric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import unittest

import numpy
import pytest

from dpnp.tests.helper import has_support_aspect64
Expand All @@ -24,7 +25,7 @@ def check_binary(self, name, xp, dtype):
return getattr(xp, name)(a, b)

@testing.for_dtypes(["e", "f", "d"])
@testing.numpy_cupy_allclose(atol=1e-5)
@testing.numpy_cupy_allclose(atol={numpy.float16: 1e-3, "default": 1e-5})
def check_unary_unit(self, name, xp, dtype):
a = xp.array([0.2, 0.4, 0.6, 0.8], dtype=dtype)
return getattr(xp, name)(a)
Expand Down
Loading