Skip to content

Fix dpnp.unique with axis=0 and 1d input #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2025
Merged

Fix dpnp.unique with axis=0 and 1d input #2530

merged 7 commits into from
Jul 17, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 17, 2025 •
edited
Loading

The PR fixes dpnp.unique with 1d input array and axis=0, equal_nan=True keywords passed where the produced result is wrong and doesn't collapse the NaNs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 17, 2025
@antonwolfy antonwolfy self-assigned this Jul 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_19 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 17, 2025 •
edited
Loading

Coverage Status

coverage: 72.092%. remained the same
when pulling 1b7d987 on unique-equal_nan-axis0-1d
into fed6925 on master.

vtavana
vtavana approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 4901cde into master Jul 17, 2025
141 of 144 checks passed
@antonwolfy antonwolfy deleted the unique-equal_nan-axis0-1d branch July 17, 2025 17:48
github-actions bot added a commit that referenced this pull request Jul 17, 2025
@github-actions
Fix dpnp.unique with axis=0 and 1d input (#2530)
0a1524f 
The PR fixes `dpnp.unique` with 1d input array and `axis=0`,
`equal_nan=True` keywords passed where the produced result is wrong and
doesn't collapse the NaNs. 4901cde
antonwolfy added a commit that referenced this pull request Sep 22, 2025
@antonwolfy
Follow up fix implemented in gh-2530
23dbe91
antonwolfy added a commit that referenced this pull request Sep 22, 2025
@antonwolfy
Merge branch 'master' into follow-up-gh-2530
b33aa5e
github-actions bot added a commit that referenced this pull request Sep 22, 2025
@github-actions
Follow up the fix implemented in gh-2530 to fix dpnp.unique with ax…
95a868b 
…is=0 and 1d input f76602e
@coveralls coveralls mentioned this pull request Sep 22, 2025
Merged
7 tasks
antonwolfy added a commit that referenced this pull request Sep 23, 2025
@antonwolfy
Follow up the fix implemented in gh-2530 to fix dpnp.unique with ax…
12c324b 
…is=0 and 1d input (#2587)

The PR improves the fix implemented in `dpnp.unique` for axis=0 and 1d
input.
Also it adds an explicit validation in case of floating axis passed.
github-actions bot added a commit that referenced this pull request Sep 23, 2025
@github-actions
Follow up the fix implemented in gh-2530 to fix dpnp.unique with ax…
0eac767 
…is=0 and 1d input (#2587)

The PR improves the fix implemented in `dpnp.unique` for axis=0 and 1d
input.
Also it adds an explicit validation in case of floating axis passed. 12c324b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vtavana