Skip to content

Unskip some linalg tests #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Unskip some linalg tests #2559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f61029a
Unskip linalg tests requiring oneMKL 2025.2
vlad-perevezentsev Aug 14, 2025
f19b43c
Exclude requires_intel_mkl_version from coverage
vlad-perevezentsev Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dpnp/tests/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ def numpy_version():
return numpy.lib.NumpyVersion(numpy.__version__)


def requires_intel_mkl_version(version):
def requires_intel_mkl_version(version): # pragma: no cover
"""
Check if Intel MKL is used and its version is greater than or
equal to the specified one.
Expand Down
19 changes: 0 additions & 19 deletions dpnp/tests/test_linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
has_support_aspect64,
is_cpu_device,
numpy_version,
requires_intel_mkl_version,
)
from .third_party.cupy import testing

Expand Down Expand Up @@ -1747,10 +1746,6 @@ def test_inv_singular_matrix(self, matrix):
assert_raises(numpy.linalg.LinAlgError, numpy.linalg.inv, a_np)
assert_raises(dpnp.linalg.LinAlgError, dpnp.linalg.inv, a_dp)

# TODO: remove skipif when Intel MKL 2025.2 is released
@pytest.mark.skipif(
not requires_intel_mkl_version("2025.2"), reason="mkl<2025.2"
)
def test_inv_singular_matrix_3D(self):
a_np = numpy.array(
[[[1, 2], [3, 4]], [[1, 2], [1, 2]], [[1, 3], [3, 1]]]
Expand Down Expand Up @@ -2766,13 +2761,6 @@ def test_slogdet_strides(self):
assert_allclose(sign_result, sign_expected)
assert_allclose(logdet_result, logdet_expected)

# TODO: remove skipif when Intel MKL 2025.2 is released
# Skip running on CPU because dpnp uses _getrf_batch only on CPU
# for dpnp.linalg.det/slogdet.
@pytest.mark.skipif(
is_cpu_device() and not requires_intel_mkl_version("2025.2"),
reason="mkl<2025.2",
)
@pytest.mark.parametrize(
"matrix",
[
Expand Down Expand Up @@ -2803,13 +2791,6 @@ def test_slogdet_singular_matrix(self, matrix):
assert_allclose(sign_result, sign_expected)
assert_allclose(logdet_result, logdet_expected)

# TODO: remove skipif when Intel MKL 2025.2 is released
# Skip running on CPU because dpnp uses _getrf_batch only on CPU
# for dpnp.linalg.det/slogdet.
@pytest.mark.skipif(
is_cpu_device() and not requires_intel_mkl_version("2025.2"),
reason="mkl<2025.2",
)
def test_slogdet_singular_matrix_3D(self):
a_np = numpy.array(
[[[1, 2], [3, 4]], [[1, 2], [1, 2]], [[1, 3], [3, 1]]]
Expand Down
5 changes: 0 additions & 5 deletions dpnp/tests/third_party/cupy/linalg_tests/test_solve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from dpnp.tests.helper import (
assert_dtype_allclose,
has_support_aspect64,
requires_intel_mkl_version,
)
from dpnp.tests.third_party.cupy import testing
from dpnp.tests.third_party.cupy.testing import _condition
Expand Down Expand Up @@ -214,10 +213,6 @@ def test_inv(self, dtype):
):
xp.linalg.inv(a)

# TODO: remove skipif when Intel MKL 2025.2 is released
@pytest.mark.skipif(
not requires_intel_mkl_version("2025.2"), reason="mkl<2025.2"
)
@testing.for_dtypes("ifdFD")
def test_batched_inv(self, dtype):
for xp in (numpy, cupy):
Expand Down
Loading