Skip to content

Unskip some linalg tests #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

Unskip some linalg tests #2559

merged 2 commits into from
Aug 18, 2025

Conversation

vlad-perevezentsev
Copy link
Contributor

This PR suggests unskipping batch tests in linalg since oneMKL 2025.2 has been released and version 2025.1 is no longer relevant.
It also excludes requires_intel_mkl_version from coverage until it is needed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Aug 14, 2025
Merged
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2559/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_8 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.126% (+0.02%) from 72.108%
when pulling f19b43c on unskip_linalg_tests
into 230ba6a on master.

ndgrigorian
ndgrigorian reviewed Aug 16, 2025
View reviewed changes
ndgrigorian
ndgrigorian approved these changes Aug 16, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.10 CI failure seems unrelated and unskipped tests are passing

LGTM!

@vlad-perevezentsev
Copy link
Contributor Author

3.10 CI failure seems unrelated and unskipped tests are passing

LGTM!

3.10 CI failure requires separate investigation and is not related to these changes.
I will look into it

@vlad-perevezentsev vlad-perevezentsev merged commit 1b94a40 into master Aug 18, 2025
105 of 115 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the unskip_linalg_tests branch August 18, 2025 10:19
github-actions bot added a commit that referenced this pull request Aug 18, 2025
@github-actions
Unskip some linalg tests (#2559)
35870e8 
This PR suggests unskipping batch tests in linalg since oneMKL 2025.2
has been released and version 2025.1 is no longer relevant.
It also excludes `requires_intel_mkl_version` from coverage until it is
needed 1b94a40
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

4 participants

@vlad-perevezentsev @coveralls @ndgrigorian @antonwolfy