chore(lint): enforce type annotations using ruff instead of in mypy#3061
Merged
chore(lint): enforce type annotations using ruff instead of in mypy#3061
Conversation
Collaborator
mkoura
commented
May 27, 2025
mkoura
commented
- Add "ANN" (type annotation) checks to ruff linting, except for test, framework, and docs files.
- Ignore ANN401 for ruff to allow untyped self/cls.
- Remove mypy per-file overrides for untyped defs in tests and framework.
- Add explicit return types to init methods in resource and clusterlib.
- Add "ANN" (type annotation) checks to ruff linting, except for test, framework, and docs files. - Ignore ANN401 for ruff to allow untyped self/cls. - Remove mypy per-file overrides for untyped defs in tests and framework. - Add explicit return types to __init__ methods in resource and clusterlib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.