Skip to content

chore(lint): enforce type annotations using ruff instead of in mypy #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
May 27, 2025
Merged

chore(lint): enforce type annotations using ruff instead of in mypy #3061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cardano_node_tests/cluster_management/resources_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class BaseFilter:
"""Base class for resource filters."""

def __init__(self, resources: tp.Iterable[str]):
def __init__(self, resources: tp.Iterable[str]) -> None:
assert not isinstance(resources, str), "`resources` can't be single string"
self.resources = resources

Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/utils/custom_clusterlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def __init__(
slots_offset: int | None = None,
socket_path: clusterlib.FileType = "",
command_era: str = consts.CommandEras.LATEST,
):
) -> None:
super().__init__(
state_dir=state_dir,
slots_offset=slots_offset,
Expand Down
20 changes: 5 additions & 15 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,14 @@ line-length = 100
line-length = 100

[tool.ruff.lint]
select = ["ARG", "B", "C4", "C90", "D", "DTZ", "E", "EM", "F", "FURB", "I001", "ISC", "N", "PERF", "PIE", "PL", "PLE", "PLR", "PLW", "PT", "PTH", "Q", "RET", "RSE", "RUF", "SIM", "TRY", "UP", "W", "YTT"]
ignore = ["B905", "D10", "D203", "D212", "D213", "D214", "D215", "D404", "D405", "D406", "D407", "D408", "D409", "D410", "D411", "D413", "ISC001", "PLR0912", "PLR0913", "PLR0915", "PLR2004", "PT001", "PT007", "PT012", "PT018", "PT023", "PTH123", "RET504", "TRY002", "TRY301", "UP006", "UP007", "UP035"]
select = ["ANN", "ARG", "B", "C4", "C90", "D", "DTZ", "E", "EM", "F", "FURB", "I001", "ISC", "N", "PERF", "PIE", "PL", "PLE", "PLR", "PLW", "PT", "PTH", "Q", "RET", "RSE", "RUF", "SIM", "TRY", "UP", "W", "YTT"]
ignore = ["ANN401", "B905", "D10", "D203", "D212", "D213", "D214", "D215", "D404", "D405", "D406", "D407", "D408", "D409", "D410", "D411", "D413", "ISC001", "PLR0912", "PLR0913", "PLR0915", "PLR2004", "PT001", "PT007", "PT012", "PT018", "PT023", "PTH123", "RET504", "TRY002", "TRY301", "UP006", "UP007", "UP035"]

[tool.ruff.lint.per-file-ignores]
"cardano_node_tests/utils/model_ekg.py" = ["N815"]
"cardano_node_tests/tests/**.py" = ["ANN"]
"framework_tests/**.py" = ["ANN"]
"src_docs/**.py" = ["ANN"]

[tool.ruff.lint.isort]
force-single-line = true
Expand All @@ -105,22 +108,9 @@ ignore_missing_imports = true
follow_imports = "normal"
no_implicit_optional = true
allow_untyped_globals = false
allow_untyped_defs = false
warn_unused_configs = true
warn_return_any = true

[[tool.mypy.overrides]]
module = "cardano_node_tests.tests.*"
allow_untyped_defs = true

[[tool.mypy.overrides]]
module = "cardano_node_tests.*.conftest"
allow_untyped_defs = false

[[tool.mypy.overrides]]
module = "framework_tests.*"
allow_untyped_defs = true

[tool.pytest.ini_options]
log_cli = true
log_level = "INFO"
Expand Down
Loading