Skip to content

Conversation

@smelc
Copy link
Contributor

@smelc smelc commented Jan 27, 2025

Note

On top of #6087 and needs also to be merged after #6068 (to have more recent cardano-api version)

Description

This PR adapts tx-generator to the removal of the ProtocolParameters type from cardano-api (which has been deprecated, see IntersectMBO/cardano-api#384).

Instead this PR makes tx-generator use the ledger type PParams era directly. The challenge is that this type is parameterized by the era, as opposed to ProtocolParameters (that was hiding it).

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/variant-adapt-to-api-removal-of-protocol-parameters-use-ledger-type-instead branch from 37a4ea0 to 2ea1216 Compare January 27, 2025 15:23
@smelc
Copy link
Contributor Author

smelc commented Feb 25, 2025

Closing as we will proceed differently in the end, as explained here: IntersectMBO/cardano-api#384 (comment)

@smelc smelc closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants