Skip to content

Conversation

@smelc
Copy link
Contributor

@smelc smelc commented Jan 16, 2025

Changelog

- description: |
    Remove the ProtocolParameters type, that has been deprecated for a while
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

  • It's deletion only
  • Execute git grep ' ProtocolParameters ' in cardano-cli and observe that there are no hits
  • Dependency on API's ProtocolParameters has been removed from cardano-node in wb | port ProtocolParameters cardano-node#6131

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Jan 28, 2025

This is blocked on merging IntersectMBO/cardano-node#6090 in cardano-node so this is going to stay in draft a little while. The performance team has been notified of 6090, but needs to act on stopping to support Byron to merge it.

@gitmachtl
Copy link
Contributor

@smelc can you give me a short brief if this impacts current cardano-cli behavior where we use the protocol-parameters file all the time?

@smelc
Copy link
Contributor Author

smelc commented Feb 24, 2025

@gitmachtl> no it doesn't affect cardano-cli, which was already adapted to this removal a while ago.

@smelc smelc force-pushed the smelc/remove-protocol-parameters branch 2 times, most recently from 6cdfa6f to 70b995d Compare February 24, 2025 14:27
@smelc smelc force-pushed the smelc/remove-protocol-parameters branch 2 times, most recently from bee5047 to 14832ab Compare February 24, 2025 15:54
@smelc
Copy link
Contributor Author

smelc commented Mar 11, 2025

Ultimately, should be merged after this is merged: IntersectMBO/cardano-node#6131

@smelc smelc force-pushed the smelc/remove-protocol-parameters branch from a244ed7 to 84d0510 Compare March 21, 2025 12:51
@smelc smelc enabled auto-merge March 21, 2025 13:00
@smelc smelc added this pull request to the merge queue Mar 21, 2025
Merged via the queue into master with commit efe0b3d Mar 21, 2025
29 checks passed
@smelc smelc deleted the smelc/remove-protocol-parameters branch March 21, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cardano-api's ProtocolParameters (it has been deprecated for a while)

4 participants