Skip to content

Conversation

@fmaste
Copy link
Contributor

@fmaste fmaste commented Feb 25, 2025

Description

ProtocolParameters had been deprecated in favor the ledger's PParams type, port ProtocolParameters to the tx-generator for cardano-api to be able to remove it.

References

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@fmaste fmaste force-pushed the fmaste/remove-protocol-parameters branch 4 times, most recently from f2a6a8f to 9ae28ed Compare February 26, 2025 13:11
@fmaste fmaste force-pushed the fmaste/remove-protocol-parameters branch from 9ae28ed to f7c8576 Compare March 18, 2025 14:01
@fmaste fmaste changed the title WIP: dummy ProtocolParameters wb | port ProtocolParameters Mar 18, 2025
@fmaste fmaste marked this pull request as ready for review March 18, 2025 15:10
@fmaste fmaste requested a review from a team as a code owner March 18, 2025 15:10
@fmaste fmaste force-pushed the fmaste/remove-protocol-parameters branch from f7c8576 to ab598cc Compare March 18, 2025 15:44
@fmaste fmaste force-pushed the fmaste/remove-protocol-parameters branch from ab598cc to a242dc0 Compare March 20, 2025 13:22
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @fmaste

@mgmeier mgmeier enabled auto-merge March 20, 2025 14:27
@mgmeier mgmeier added this pull request to the merge queue Mar 20, 2025
Merged via the queue into master with commit 615800f Mar 20, 2025
23 checks passed
@mgmeier mgmeier deleted the fmaste/remove-protocol-parameters branch March 20, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants