[DO NOT MERGE] Network intergration for cardano-node 10.7
#1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method leverages a corresponding method recently exposed by ledger side to provide encoded transaction sizes to eg. diffusion layer. - Integrate new tx submission protocol - txWireSize: Byron txs overhead We need to add 2 bytes overhead for `EncCBOR (AMempoolPayload ByteString)`. See: https://github.com/IntersectMBO/cardano-ledger/blob/cardano-ledger-byron-1.1.0.0/eras/byron/ledger/impl/src/Cardano/Chain/MempoolPayload.hs#L73-L81 - txWireSize: wrapCBORinCBOR overhead for Shelley txs - Take into account the overhead of `wrapCBORinCBOR`. - txWireSize: added overhead for HardFork txs - Added HFC overhead. This overestimates it, if the HFC is disabled. - txWireSize: added tests - Use txWireSize when computing tx-sizes for ouroboros-network Co-Author: Armando Santos <[email protected]> Co-Author: Marcin Szamotulski <[email protected]> Co-Author: Marcin Wójtowicz <[email protected]>
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
b3d3d92 to
a89747b
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
a89747b to
f020af8
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
f020af8 to
49cd4cb
Compare
This version is compatible with QuickCheck 2.15 and lower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #1816
TODO:
kes-agentmust point tomainnetworkmust point tomaintyped-protocols