Allow using QuickCheck < 2.16
#5276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
force-pushed
the
geo2a/10.7-integration
branch
2 times, most recently
from
543f0fe to
5f64770
Compare
geo2a
changed the title
geo2a
force-pushed
the
geo2a/10.7-integration
branch
from
5f64770 to
c49ee1e
Compare
geo2a
force-pushed
the
geo2a/10.7-integration
branch
2 times, most recently
from
7c9d0a9 to
d137062
Compare
Contributor
Author
|
It seems like we are hitting a false positive of I'm not sure there's a solution to this issue. |
geo2a
force-pushed
the
geo2a/10.7-integration
branch
6 times, most recently
from
6f93ac9 to
0da531b
Compare
coot
force-pushed
the
geo2a/10.7-integration
branch
from
cc39f97 to
8e9d895
Compare
coot
approved these changes
Jan 13, 2026
Collaborator
coot
left a comment
coot
left a comment
There was a problem hiding this comment.
LGTM, with some minor adjustments.
| ghc-options: -Wno-redundant-constraints | ||
| ghc-options: | ||
| -Wno-redundant-constraints | ||
| -Wno-unused-packages |
Collaborator
There was a problem hiding this comment.
Could you add a comment, that this is only required until we support quickcheck-monoids.
Comment on lines
+92
to
+93
| import "quickcheck-monoids" Test.QuickCheck.Monoids | ||
| #endif |
Collaborator
There was a problem hiding this comment.
You can squash this on top of the first commit, which contain similar changes.
Comment on lines
12
to
13
|
|
||
| {-# LANGUAGE CPP #-} | ||
| {-# LANGUAGE CPP #-} |
Collaborator
There was a problem hiding this comment.
Remove the empty line, sort the pragmas and squash it onto the commit where it was introduced.
geo2a
force-pushed
the
geo2a/10.7-integration
branch
from
8e9d895 to
1cf2b22
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
geo2a
force-pushed
the
geo2a/10.7-integration
branch
from
1cf2b22 to
0d1b5d5
Compare
geo2a
force-pushed
the
geo2a/10.7-integration
branch
from
0d1b5d5 to
3991765
Compare
For not, '-Wno-redundant-constraints' is needed in testing libraries to prevent false-positives that lead to build errors with `-Werror`. See https://gitlab.haskell.org/ghc/ghc/-/issues/24173 for details.
geo2a
force-pushed
the
geo2a/10.7-integration
branch
from
3991765 to
2b1777f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is necessary for Consensus to build with the current Network