Fix exception because of premature handle closing in V2 forkers #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/forkers-2
branch
from
30e9fd9 to
fdf1488
Compare
Contributor
Author
|
I'm thinking now that maybe we could even share the same ledgerseq between the LedgerDB and the forker, and commit the whole thing, then closing only the leftovers from the LedgerDB. This would remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifested here: https://github.com/IntersectMBO/ouroboros-consensus/actions/runs/21365715331/job/61496793074?pr=1841
Only second commit actually changes the logic.