Skip to content

Fix exception because of premature handle closing in V2 forkers #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasagredo merged 1 commit into from
Feb 10, 2026
Merged

Fix exception because of premature handle closing in V2 forkers #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ouroboros-consensus/changelog.d/20260210_130157_javier.sagredo_forkers_2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
For top level release notes, leave all the headers commented out.
-->

### Patch

- Fix leaked handles on uncommitted forkers in V2 LedgerDB.

<!--
### Non-Breaking

- A bullet item for the Non-Breaking category.

-->
<!--
### Breaking

- A bullet item for the Breaking category.

-->
4 changes: 3 additions & 1 deletion ...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/LedgerDB/V2/Forker.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ implForkerPush env newState =

let lseq' = extend (StateRef st newtbs) lseq

atomically $ writeTVar (foeLedgerSeq env) lseq'
atomically $ do
writeTVar (foeLedgerSeq env) lseq'
modifyTVar (foeCleanup env) (>> close newtbs)
)

implForkerCommit ::
Expand Down
Loading