new option: CustomStyleSheet/CustomFavicon/EnableEdit#159
new option: CustomStyleSheet/CustomFavicon/EnableEdit#159maikebing merged 3 commits intoIoTSharp:masterfrom Bonnie2980:master
Conversation
|
If options. EnableEdit = true, click the "New" button on the "Job" "Trigger" page, and throw the following exception HandlebarsDotNet.Compiler.HandlebarsUndefinedBindingException:“EnableEdit is undefined” |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new configuration options—CustomStyleSheet, CustomFavicon, and EnableEdit—and integrates them into the UI rendering and authentication flow. Key changes include adding new Handlebars helpers, propagating the EnableEdit flag in multiple controllers and views, and updating sample projects to use custom static file middleware and configuration for assets.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/SilkierQuartz/Helpers/HandlebarsHelpers.cs | Added Handlebars helpers for CustomStyleSheet and CustomFavicon. |
| src/SilkierQuartz/Controllers/*.cs | Updated controllers to pass the EnableEdit option to views and models. |
| src/SilkierQuartz/Authorization/SilkierQuartzAuthenticationOptions.cs | Modified authentication options to use instance properties instead of constants. |
| sample2/Program.cs & sample/Startup.cs | Configured custom static files for the new CSS and favicon options and updated job registrations. |
| sample/Jobs/HelloJobAuto.cs | Updated SilkierQuartz attribute parameters with additional grouping and description values. |
| Others | Updated package versions and minor formatting fixes. |
Comments suppressed due to low confidence (1)
sample/Jobs/HelloJobAuto.cs:11
- The parameter name 'Desciption' appears to be a typo; consider renaming it to 'Description' for clarity and consistency.
[SilkierQuartz(5, Group = "example", Desciption = "this e sq test", TriggerDescription = "_hellojobauto", TriggerGroup = "SilkierQuartz")]
| } | ||
| } | ||
|
|
||
| ViewBag.EnableEdit = EnableEdit; |
There was a problem hiding this comment.
[nitpick] The assignment 'ViewBag.EnableEdit = EnableEdit' is repeated in multiple controllers. Consider centralizing this logic in a base controller or helper method to reduce duplication.
…" "Trigger" page, and throw the following exception #159
No description provided.