Merged
Conversation
Updated ReflectorNet.dll binary and incremented the project version to 0.9.2 in both package.json and Server/version to reflect the new changes.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project version to 0.9.2 to align with the new ReflectorNet.dll binary switch from netstandard2.1 to netstandard2.0.
- Bumped package.json version to 0.9.2
- Updated Server/version file to 0.9.2
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Assets/root/package.json | Updated "version" from 0.9.1 to 0.9.2 |
| Assets/root/Server/version | Updated version string to 0.9.2 |
Replaced the ReflectorNet package reference with a direct DLL reference in the server project and added the corresponding .meta file. Updated ObjectRefConverter to throw an exception if ObjectRef type name is null. Adjusted test code to use JsonUtils.Schema for schema and property lookups.
…ance error logging for unsupported types
…l.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…amline error logging in shader handling
…ity-MCP into update/json-schema
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…order and enhance readability
…or logging and padding for better readability
… reflection converters
…ection converters for improved readability
…lude recent changes and improvements
Added RS_UnityEngineBounds, RS_UnityEngineBoundsInt, RS_UnityEngineRect, and RS_UnityEngineRectInt converters and registered them in startup. Improved logging in reflection converters to include convertor type and better error/success messages. Enhanced type validation for GameObject field/property assignment and updated Sprite/Material converters for more informative output.
… for improved readability - Updated GameObject.DestroyComponents.cs to use GetTypeName for component type logging. - Modified GameObject.Modify.cs to utilize GetTypeName for error messages related to missing components. - Changed GameObject.cs to replace FullName with GetTypeName in error messages for invalid property and field types. - Refactored Reflection.cs to use IsMatch for parameter type checking instead of FullName. - Added necessary using directives for ReflectorNet in multiple files. - Updated Color32Converter, ColorConverter, Matrix4x4Converter, QuaternionConverter, Vector2Converter, Vector3Converter, and Vector4Converter to use GetTypeId and JsonUtils.Schema for JSON schema definitions. - Enhanced error messages in RS_UnityEngineGameObject.Editor.cs and RS_UnityEngineGameObject.cs to use GetTypeName for better clarity. - Updated ObjectRefConverter.cs to use GetTypeId for ObjectRef type identification. - Adjusted test cases in TestJsonSchema.cs and TestJsonSerialize.cs to utilize GetTypeName for improved error reporting.
…recent changes and improvements
…packages-lock.json for improved compatibility and performance
update: Json schema improvements
IvanMurzak
changed the title
netstandard2.1 to netstandard2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across different areas of the project, including enhancements to Unity scene setup, improvements to API tooling, and updates to metadata files. Below is a breakdown of the most significant changes:
Unity Scene Setup
NoLightmap.unitywith default settings for occlusion culling, render settings, lightmap settings, navigation mesh settings, and basic GameObjects like a camera and directional light. This provides a foundational scene for further development..metafile for the newNoLightmap.unityscene to ensure proper asset tracking in Unity.API Tooling Enhancements
GameObject.DestroyComponentsandGameObject.ModifyAPIs to use theGetTypeName(pretty: false)method for improved type name formatting in error messages and logs. This enhances clarity and debugging. [1] [2] [3] [4]GameObject.ModifyAPI by reordering method parameters and refining descriptions to better align with expected usage patterns.Reflection.MethodCallandReflectionAPIs to use named parameters for logger injection, improving code readability and maintainability. [1] [2] [3]Metadata Updates
.metafiles for test runner-related scripts (e.g.,TestFilterParameters,TestResultCollector) to ensure Unity tracks these assets correctly. These changes standardize asset metadata across the project. [1] [2] [3] [4] [5] [6]Miscellaneous
HDRP, in the.vscode/settings.jsonfile, likely for improved IntelliSense or project-specific configuration.These changes collectively enhance the project's functionality, maintainability, and development environment setup.