Support BibLaTeX datamodel validations #13693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
jablib/src/test/java/org/jabref/logic/biblog/BibtexLogParserTest.java
Outdated
Show resolved
Hide resolved
jablib/src/test/java/org/jabref/logic/biblog/BibtexLogParserTest.java
Outdated
Show resolved
Hide resolved
| if (message.startsWith(EMPTY_FIELD_PREFIX)) { | ||
| fieldName = message.substring(EMPTY_FIELD_PREFIX.length()).trim(); | ||
| fieldName = FieldFactory.parseField(fieldName).getName(); | ||
| // For BiblaTex warnings |
There was a problem hiding this comment.
Comment adds no value as it merely restates what is obvious from the code. Should be removed or enhanced with additional context.
There was a problem hiding this comment.
Do not camel case latex or bibtex or biblatex in variable names.
koppor
requested changes
Aug 14, 2025
…tex and bibtex in variable names instead of camel case.
|
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
koppor
approved these changes
Aug 28, 2025
Comment on lines
52
to
56
| /// **Parameters:** | ||
| /// * `line` - The single line from the .blg file to parse. | ||
| /// | ||
| /// **Returns:** | ||
| /// * An `Optional` containing a `BibWarning` if a match is found, or an empty `Optional` otherwise. |
There was a problem hiding this comment.
Please use JavaDoc format - see deleted code for the format to be used.
I fixed in 7ee3497.
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
added a commit
that referenced
this pull request
Aug 28, 2025
…n-c23b1a88-5c29-46a2-a007-701edd344b9b' into jetbrains-junie-issue-13623-run-c23b1a88-5c29-46a2-a007-701edd344b9b * upstream/jetbrains-junie-issue-13623-run-c23b1a88-5c29-46a2-a007-701edd344b9b: Streamline code for getTabTitle() (#13781) Add missing variables Reformat BibTex in Show BibTex Source (#13761) Auto publish before JBang tests (#13779) Hotfix: calling of publish.yml Support BibLaTeX datamodel validations (#13693) Auto add and remove of "status: changes-required" label (#13778) New Crowdin updates (#13777) Restore local-only Git behavior for SLR to fix repository initialization error (#13775) Use vanilla hashset (#13771) Fix Springer Fetcher names (#13770) Fix condition Publish SNAPSHOT on jablib change (#13774) Adapt as per new set of checks (#13772) Bump jablib/src/main/resources/csl-styles from `1194364` to `17cfa60` (#13750) Fix path (#13769) Mode aware consistency check (#13584) Refine JBang check (#13765) Add Language Server to the UI and add the integrity/consistency check (#13697) Fix/remove comment code (#13763)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13318
I've updated the
BibtexLogParserclass by adding a newBIBLATEXT_WARNING_PATTERNto specifically recognize and parse Biber's data model validation warnings. Concurrently, a new@ParameterizedTestwas implemented inBibtexLogParserTestto thoroughly test this new pattern, ensuring the parser correctly extracts information from these distinct warning messages. This enables JabRef to now support a wider range of Biber's log outputs.Steps to test
You can test the business by just running
parsesBiblaTexValidationWarningstest inBibtexLogParserTest.In other way, you can also see validation messages in
Check Integrityin JabRef.The warnings in the screenshot has been catched by the new pattern.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)