Add new check for format #13909
Add new check for format #13909
Conversation
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
|
|
||
| @Inject | ||
| private SrvStateManager srvStateManager; | ||
| private SrvStateManager srvStateManager; |
There was a problem hiding this comment.
The patch reformats code without adding new statements, which contradicts the guideline that code should not be reformatted only because of syntax. This change should be reverted unless new statements are added.
|
|
||
| @Inject | ||
| private FilesToServe filesToServe; | ||
| private FilesToServe filesToServe; |
There was a problem hiding this comment.
The patch reformats code without adding new statements, which contradicts the guideline that code should not be reformatted only because of syntax. This change should be reverted unless new statements are added.
koppor
added
the
dev: code-quality
|
Your pull request needs to link an issue correctly. To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:
Examples
|
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
@trag-bot didn't find any issues in the code! ✅✨ |
* upstream/main: Add new check for format (#13909) Consistent casing in fieldnames (#13867) Revert "Pressing TAB in last field in entry editor moves focus to the next ta…" (#13912) Fix YAML Fix on-pr-opened-updated.yml syntax Pressing TAB in last field in entry editor moves focus to the next tab's first field (#13870) Modularize JabSrv (#13908) New translations jabref_en.properties (Italian) (#13907) Remove wrong `assert` statement (#13906) Add .git-blame-ignore-revs (#13884) Do not show transprot info messages (#13904) Pubmed api key support (#13899) Fix warnings for native access Fix automerge workflow (#13903) Add comment on issue on binary (#13902) Have checkstyle and VCS configuration distributed (#13900) Add unknown field to lsp consistency check (#13880) Put config for general tab if missing (#13901) Fix autosave manager exception on shutdown (#13882)
3 participants
Tries to use an action to check if all code conforms to our style
Follow-up to #13885
Had to disable JavaDoc formatting, because of
I patched one action to get it working
Some collections of actions - for reference
Cannot disable JavaDoc parameter alignment, because all JavaDoc will be changed:
IntelliJ itself recommends to check-in configuration into VCS: https://www.jetbrains.com/help/idea/configure-project-settings.html?_cl=MTsxOzE7OTRVRlhLb3ZQWXA3TEdjQXlRT3RrYW1jUU1lWDdNN25DNGZnNk53R0h6ZWVTMktiWjVDS1NQYmxhRjF5NkNIWjs%3D#share-project-through-vcs
Alternative is backup-and-sync: https://www.jetbrains.com/help/idea/sharing-your-ide-settings.html?_cl=MTsxOzE7OTRVRlhLb3ZQWXA3TEdjQXlRT3RrYW1jUU1lWDdNN25DNGZnNk53R0h6ZWVTMktiWjVDS1NQYmxhRjF5NkNIWjs%3D
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)