-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Add new check for format #13909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add new check for format #13909
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a273d8c
Add new check for format
koppor 6f9b353
Introduce formatting issue
koppor 6c848c9
Merge remote-tracking branch 'origin/main' into reformat-check
koppor e7261bd
Merge remote-tracking branch 'origin/main' into reformat-check
koppor 3a98a4a
Fix quotes
koppor 533bc5b
Try to fix parameter
koppor 0e0ba7a
Change action
koppor 6f285ff
Add failing
koppor 4589701
Add another bad thing
koppor e384029
Add step name
koppor 5826af3
Output changed files
koppor fd43580
Output changes
koppor d08fc55
Do not align parameters
koppor c98c62e
Disable JavaDoc formatting
koppor d22a472
Comment on wrong format
koppor 7d702a8
Revert "Add another bad thing"
koppor fc5cf34
Revert "Introduce formatting issue"
koppor 7a4edc5
Remove empty lines
koppor 7e4d469
Fix formatting issue
koppor 48e757b
Revise code style message in ghprcomment.yml
koppor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,10 +19,10 @@ | |
| public class LibrariesResource { | ||
|
|
||
| @Inject | ||
| private SrvStateManager srvStateManager; | ||
| private SrvStateManager srvStateManager; | ||
|
|
||
| @Inject | ||
| private FilesToServe filesToServe; | ||
| private FilesToServe filesToServe; | ||
|
||
|
|
||
| @Inject | ||
| private Gson gson; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch reformats code without adding new statements, which contradicts the guideline that code should not be reformatted only because of syntax. This change should be reverted unless new statements are added.