-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix #14556 Removed the extra space occupied by the table. #15360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+22
−1
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
05b4ebb
Fix #14556 Removed the extra space occupied by the table, The table i…
OfficialArpitNege b933236
Fix #14556 Removed the extra space occupied by the Table
OfficialArpitNege 075f4d6
Update CHANGELOG.md for #14556
OfficialArpitNege 6032437
Improve table layout and address review feedback
OfficialArpitNege ec41995
Merge branch 'main' into fix-issue
OfficialArpitNege 23dd575
Merge branch 'main' into fix-issue
OfficialArpitNege 5fe08e9
Use constants for row height and header estimate to remove magic numbers
OfficialArpitNege 849f8ae
Fix Checkstyle: move constants above FXML fields
OfficialArpitNege 86722a0
Merge branch 'main' into fix-issue
OfficialArpitNege 4996b61
Remove extra blank line to satisfy Checkstyle
OfficialArpitNege b04db42
Merge branch 'main' into fix-issue
OfficialArpitNege 58ce1b4
Merge branch 'main' into fix-issue
subhramit 5e2f61b
Merge branch 'main' into fix-issue
OfficialArpitNege 4ee1276
Remove redundant comment in WebSearchTab (line 115)
OfficialArpitNege File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use constants instead of magic numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I’ve replaced the magic numbers with named constants (FONT_HEIGHT_MULTIPLIER, DEFAULT_ROW_HEIGHT, HEADER_HEIGHT_ESTIMATE) and added brief comments to clarify their purpose. The table layout still adapts dynamically to the font size.