Fix #14556 Removed the extra space occupied by the table.

[OfficialArpitNege]

Related issues and pull requests

Closes #14556

PR Description

  1. Removed the extra space occupied by the websearch table to improve the layout.
  2. The main intention was to make the interface cleaner.

Steps to test

1. Open the app -> File -> Preferences -> Web Search

Checklist

• I own the copyright of the code submitted and I license it under the MIT license
• I manually tested my changes in running JabRef (always required)
• [/] I added JUnit tests for changes (if applicable)
• I added screenshots in the PR description (if change is visible to the user)
• [/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
• I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
• [/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

[github-actions]

Hey @OfficialArpitNege! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide.

Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures.

[qodo-free-for-open-source-projects]

Review Summary by Qodo

Fix WebSearch table excessive whitespace and dynamic sizing

🐞 Bug fix ✨ Enhancement

Walkthroughs

Description

• Fixed excessive whitespace in WebSearch table layout
• Implemented dynamic table height calculation based on content
• Added fixed cell size for consistent row rendering
• Table now adjusts height when items are added or removed

Diagram

flowchart LR
  A["WebSearchTab"] -->|"setFixedCellSize"| B["Table Row Height"]
  A -->|"adjustTableHeight"| C["Dynamic Height Calculation"]
  C -->|"header + rows + padding"| D["Optimized Layout"]
  E["Item Changes"] -->|"InvalidationListener"| C

Loading

File Changes

1. jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java 🐞 Bug fix +14/-0

Dynamic table height and fixed cell sizing

• Added constants for fixed table row height (30.0) and header height (32.0)
• Set fixed cell size on table to prevent variable row heights
• Implemented adjustTableHeight() method to dynamically calculate table dimensions
• Added listener to recalculate table height when items are added or removed

jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java

---

2. CHANGELOG.md 📝 Documentation +1/-0

Document WebSearch table layout fix

• Added entry documenting the fix for WebSearch table extra space issue
• References issue #14556 with link to GitHub issue tracker

CHANGELOG.md

---

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

1. Websearch wording in changelog ☑ 📘 Rule violation ✓ Correctness

Description

The new CHANGELOG entry uses the wording Websearch, which is inconsistent with the UI/tab name
Web search and reads like a typo. This is user-facing text and should be professional and precise.

Code

CHANGELOG.md[40]

+- We fixed an issue where the Websearch table had extra space, to improve the layout. [#14556](https://github.com/JabRef/jabref/issues/14556)

Evidence

PR Compliance ID 29 requires user-facing text to be free of typos and professionally written; the
added CHANGELOG entry contains inconsistent/typo-like wording (Websearch) for the feature name.

CHANGELOG.md[40-40]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The CHANGELOG entry uses inconsistent/typo-like wording (`Websearch`) in user-facing release notes.
## Issue Context
The UI uses `Web search` as the feature/tab name, so the release note should match and be professionally phrased.
## Fix Focus Areas
- CHANGELOG.md[40-40]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. adjustTableHeight hard-codes heights ☑ 📘 Rule violation ⛯ Reliability

Description

The table height is computed from hard-coded pixel constants and then forced via pref/min/max
heights, which can make the UI layout less responsive across DPI/themes/font sizes. This risks
reintroducing layout issues on different environments instead of relying on responsive layout
mechanisms.

Code

jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java[R186-191]

+    private void adjustTableHeight() {
+        double height = TABLE_HEADER_HEIGHT + (searchEngineTable.getItems().size() * TABLE_ROW_HEIGHT) + 2.0;
+        searchEngineTable.setPrefHeight(height);
+        searchEngineTable.setMinHeight(height);
+        searchEngineTable.setMaxHeight(height);
+    }

Evidence

PR Compliance ID 33 requires responsive UI layout and discourages hard-coded pixel constraints; the
new code introduces fixed pixel constants and forces the control height to an exact computed value
via pref/min/max height setters.

jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java[84-85]
jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java[186-191]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The current approach hard-codes pixel heights (`TABLE_ROW_HEIGHT`, `TABLE_HEADER_HEIGHT`) and forces the table size via `setPrefHeight`, `setMinHeight`, and `setMaxHeight`. This can reduce responsiveness across DPI/themes/fonts and conflicts with the guideline to avoid hard-coded pixel constraints.
## Issue Context
This change is meant to remove extra empty space, but should still behave well with different font sizes and UI scaling.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java[84-85]
- jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java[186-191]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[github-actions]

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

[calixtus]

Please use constants instead of magic numbers

[OfficialArpitNege]

Thanks for the review! I’ve replaced the magic numbers with named constants (FONT_HEIGHT_MULTIPLIER, DEFAULT_ROW_HEIGHT, HEADER_HEIGHT_ESTIMATE) and added brief comments to clarify their purpose. The table layout still adapts dynamically to the font size.

[OfficialArpitNege]

Hi @calixtus if you have time could you please review this pr , Happy to make any changes if needed , Thanks.

[subhramit]

@OfficialArpitNege please don't resolve comments yourselves as we use them for tracking requested changes

[subhramit]

redundant comment

[OfficialArpitNege]

I have removed the redundant comment and commited the change ! Thanks for the review .

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 4ee1276
▶️ Tests: 10205 executed
⚪️ Checks: 55/55 completed

---

Learn more about TestLens at testlens.app.