Remove global basis citations and register math-source refs per case#4746
Merged
JacquesCarette merged 2 commits intomainfrom Feb 10, 2026
Merged
Remove global basis citations and register math-source refs per case#4746JacquesCarette merged 2 commits intomainfrom
JacquesCarette merged 2 commits intomainfrom
Conversation
Xinlu-Y
requested review from
JacquesCarette,
bmaclach,
cd155,
samm82 and
smiths
as code owners
smiths
approved these changes
Feb 10, 2026
Collaborator
smiths
left a comment
smiths
left a comment
There was a problem hiding this comment.
I've reviewed this PR from the point of view of changes to stable. I'm in full support of the changes. The definition of a point and a line makes sense in GamePhysics (where it is still included), but it does not make sense in the other examples. My guess is that code was copied in the past and the line and the point references just propagated that way through our examples. Only having references that correspond to actual citations in the document makes more sense. 😄
JacquesCarette
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, #4727 added
cartesianWiki,lineSource, andpointSourceglobally for all cases to avoid missing refs. That fixed missing-reference failures short term, but over-included bibliography entries in unrelated cases.This pr makes citation inclusion explicit at case level.