Skip to content

refactor noun phrase to english#4747

Closed
JoeZZG wants to merge 1 commit intomainfrom
refactor-nounphrase-to-english
Closed

refactor noun phrase to english#4747
JoeZZG wants to merge 1 commit intomainfrom
refactor-nounphrase-to-english

Conversation

@JoeZZG
Copy link
Collaborator

@JoeZZG JoeZZG commented Feb 10, 2026

From Refactors wiki under drasil-lang:

move Language.Drasil.NounPhrase to Language.Drasil.NaturalLanguage.English.NounPhrase

NounPhrase modules are moved to a new path in drasil-lang

Files moved via git mv:

git mv .../NounPhrase.hs             -> .../NaturalLanguage/English/NounPhrase.hs
git mv .../NounPhrase/Core.hs        -> .../NaturalLanguage/English/NounPhrase/Core.hs
git mv .../NounPhrase/Combinators.hs -> .../NaturalLanguage/English/NounPhrase/Combinators.hs
git mv .../NounPhrase/README.md      -> .../NaturalLanguage/English/NounPhrase/README.md

@JacquesCarette
Copy link
Owner

@JoeZZG you should summarize what we said at the meeting here.

@JoeZZG
Copy link
Collaborator Author

JoeZZG commented Feb 11, 2026

At the meeting, the suggested two comments are:

First commit: only move files with git mv (no real content changes)
Second commit: make the actual edits

@JacquesCarette
Copy link
Owner

So I guess this is not actually ready for review?

@JoeZZG JoeZZG closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants