Skip to content

Update UX layout to fit inside the Window (instead of resizing Window to match layout)#143

Merged
JamieSinn merged 4 commits intoJamieSinn:mainfrom
jamesdooley4:resizeUxUpdate
Mar 3, 2025
Merged

Update UX layout to fit inside the Window (instead of resizing Window to match layout)#143
JamieSinn merged 4 commits intoJamieSinn:mainfrom
jamesdooley4:resizeUxUpdate

Conversation

@jamesdooley4
Copy link
Contributor

Addresses #134

@jamesdooley4 jamesdooley4 marked this pull request as ready for review March 3, 2025 02:48
@jamesdooley4
Copy link
Contributor Author

Also includes #142 so please complete that first.

@sciencewhiz
Copy link
Contributor

This does make everything fit with a scroll bar for me

image

Comment on lines +20 to +23
<Grid.RowDefinitions>
<RowDefinition Height="*" />
<RowDefinition Height="50" />
</Grid.RowDefinitions>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart idea on the row max

@JamieSinn
Copy link
Owner

For future reference - you can do something called a "stacked PR" https://www.stacking.dev/ - so that once the dependant PR is merged - ths autorebases to main without the other changes doubled up

@JamieSinn JamieSinn merged commit 0b18f20 into JamieSinn:main Mar 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants