Merged
Conversation
igordmn
commented
Mar 7, 2025
| @@ -0,0 +1,19 @@ | |||
| #!/bin/bash | |||
Collaborator
Author
There was a problem hiding this comment.
- Merge https://youtrack.jetbrains.com/issue/CMP-7738/Compose-fails-to-sync-in-Bazel fixes
- Merge this PR
- Modify the check on CI
Collaborator
Author
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
I reverted the check on CI. There some warnings there:
https://teamcity.jetbrains.com/buildConfiguration/JetBrainsPublicProjects_Compose_Dev/5048030?buildTab=dependencies&mode=list&state=failed&type=snapshot&showLog=5048026_13096_379&logFilter=debug&logView=flowAware#5048026
03:59:51 [WARNING [m] Could not validate integrity of download from https://maven.pkg.jetbrains.space/public/p/compose/dev/org/jetbrains/compose/animation/animation-desktop/1.8.0+dev2231/animation-desktop-1.8.0+dev2231.jar: Checksum validation failed, no checksums available
Collaborator
Author
There was a problem hiding this comment.
eymar
approved these changes
Mar 19, 2025
igordmn
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Mar 19, 2025
#1927 doesn't work for `pom` files. We have these dependencies: ``` [INFO] +- org.jetbrains.compose.material3:material3-desktop:jar:9999.0.0-SNAPSHOT:compile [INFO] | +- androidx.collection:collection-jvm:jar:1.5.0-beta01:runtime ``` Because: - material3 depends on `project(":collection:collection")` - project dependencies are replaced by the redirecting artifact - `pom` files [don't contain](https://youtrack.jetbrains.com/issue/CMP-7803/collection-compatibility-stub-annotation-compatibility-stub-arent-in-the-dependencies-in-pom-files) any transitive dependencies (comparing to Gradle) ## Testing The check JetBrains/compose-multiplatform#5258 doesn't fail ## Release Notes N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script for extended CI check to not miss issues like https://youtrack.jetbrains.com/issue/CMP-7738/Compose-fails-to-sync-in-Bazel
Testing
doesn't fail on the latest jb-main, fails on 1.8.0-alpha04
Release Notes
N/A