Skip to content

Maven Project. Fail on warnings #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igordmn merged 3 commits into from
Mar 19, 2025
Merged

Maven Project. Fail on warnings #5258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2463a3d
Maven Project. Fail on warnings
igordmn Mar 7, 2025
2269980
Update README.md
igordmn Mar 19, 2025
16f4ddb
Update check.sh
igordmn Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/templates/maven-test-project/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
The purpose of this test project is to check if Compose Multiplatform is resolvable via pom files, which are used by JPS, which is used by IntelliJ

```
mvn install exec:java -Dexec.mainClass="MainKt" -Dkotlin.version=2.1.0 -Dcompose.version=1.8.0-alpha02
./check.sh -Dkotlin.version=2.1.0 -Dcompose.version=1.8.0-alpha02
```
20 changes: 20 additions & 0 deletions ci/templates/maven-test-project/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/bin/bash
Copy link
Collaborator Author

@igordmn igordmn Mar 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@igordmn igordmn Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jetbrains.team/p/ui/repositories/compose-teamcity-config/revision/05477a4d7da9d7f980cb0063485ec09dc490a34f

Copy link
Collaborator Author

@igordmn igordmn Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the check on CI. There some warnings there:
https://teamcity.jetbrains.com/buildConfiguration/JetBrainsPublicProjects_Compose_Dev/5048030?buildTab=dependencies&mode=list&state=failed&type=snapshot&showLog=5048026_13096_379&logFilter=debug&logView=flowAware#5048026

03:59:51   [WARNING [m] Could not validate integrity of download from https://maven.pkg.jetbrains.space/public/p/compose/dev/org/jetbrains/compose/animation/animation-desktop/1.8.0+dev2231/animation-desktop-1.8.0+dev2231.jar: Checksum validation failed, no checksums available

Copy link
Collaborator Author

@igordmn igordmn Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://youtrack.jetbrains.com/issue/CMP-7816/Space-maven-repo-doesnt-contain-checksums-for-some-versions


set -o pipefail

tempfile=$(mktemp)

# Pipe output to the file and terminal
if ! mvn clean install exec:java -Dexec.mainClass="MainKt" "$@" | tee "$tempfile"; then
exit 1
fi

# For failing on warnings like
# [WARNING] The POM for org.jetbrains.kotlin:kotlin-stdlib:jar:unspecified is missing, no dependency information available
#
# There is no a flag in Maven to fail on warnings in dependency resolution

if grep -q "\[WARNING\]" "$tempfile"; then
echo "[ERROR] Warnings found"
exit 1
fi