-
Notifications
You must be signed in to change notification settings - Fork 4
chore: miscellaneous project updates #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (86.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Okie doke, I think things here are ready for a review now |
cadojo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much! I don't have any code comments. I've got one question, and one change request.
-
Where did all of the lints come from? Is that
Aqua? -
Could you please change the PR title to something like "chore: miscellaneous project updates"? And could you take the "What's Changed" bullets and instead make them Conventional Commits footers? Basically, could you remote the bullet syntax and make every bullet a "chore", "test", "ci", "style", or "feat"?
|
Oh also please disregard the CodeCov CI job failure, I'll mark that check optional. |
|
Awesome, happy to. Do you mean to just do a rebase reword on the commit messages? Conventional commits look really useful, thanks for the link!
Oh shoot, are you talking about the various whitespace alignments and newlines added? In my attempt to start internalizing some of the guidelines from the various style guides floating around, I do that without thinking sometimes. I can undo those bits if it is distracting to the rest of this PR |
|
No need to rebase any commits! The squash commit message will be the PR title, followed by the PR body. I recommend removing the what's changed header, and changing the bulleted list to match the "keyword: text" syntax for conventional commits. Essentially the PR body will provide "footer" conventional commit messages. (I can do this myself later today too! I'm on mobile at the moment.) Thank you as always! |
|
Ahh, gotcha. Same, will let you make the changes when you're back, and I'll be sure to use that as a template moving forward 👍🏾 |
|
Thank you! Merging this so we can merge #279. |
build: use
[workspace]build: use
test/Project.tomlchore: bump LTS to Julia v1.10
chore(docs): add some dev docs (e.g., how to run tests locally with
ENVvar)chore: use
MTK.D_nounits as DandMTK.t_nounits as tin place ofMTK.Differential(t)and@independent_variables t, respectivelychore: update README badges
style: use explicit imports
style: prefer
[ ; ]overvcat, andf(; kwarg)overf(; kwarg = kwarg)style: drop extra sets of parentheses around array vars
style: right align matrix literals
style: consolidate vars and params
refactor: simplify conditional logic for
Systemconstructiontest: add Aqua.jl tests