Skip to content

Conversation

@icweaver
Copy link
Member

@icweaver icweaver commented Dec 29, 2025

build: use [workspace]
build: use test/Project.toml
chore: bump LTS to Julia v1.10
chore(docs): add some dev docs (e.g., how to run tests locally with ENV var)
chore: use MTK.D_nounits as D and MTK.t_nounits as t in place of MTK.Differential(t) and @independent_variables t, respectively
chore: update README badges
style: use explicit imports
style: prefer [ ; ] over vcat, and f(; kwarg) over f(; kwarg = kwarg)
style: drop extra sets of parentheses around array vars
style: right align matrix literals
style: consolidate vars and params
refactor: simplify conditional logic for System construction
test: add Aqua.jl tests

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 96.36364% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.55%. Comparing base (e44419b) to head (89ecfea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/AstrodynamicalSolvers/src/Propagation.jl 81.81% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (86.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   56.43%   55.55%   -0.89%     
==========================================
  Files          13       13              
  Lines        1212     1188      -24     
==========================================
- Hits          684      660      -24     
  Misses        528      528              
Flag Coverage Δ
AstrodynamicalCalculations.jl 51.09% <ø> (ø)
AstrodynamicalModels.jl 64.98% <100.00%> (-3.00%) ⬇️
AstrodynamicalSolvers.jl 64.62% <86.66%> (ø)
GeneralAstrodynamics.jl 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icweaver
Copy link
Member Author

Okie doke, I think things here are ready for a review now

@icweaver icweaver marked this pull request as ready for review December 31, 2025 05:05
Copy link
Collaborator

@cadojo cadojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much! I don't have any code comments. I've got one question, and one change request.

  • Where did all of the lints come from? Is that Aqua?

  • Could you please change the PR title to something like "chore: miscellaneous project updates"? And could you take the "What's Changed" bullets and instead make them Conventional Commits footers? Basically, could you remote the bullet syntax and make every bullet a "chore", "test", "ci", "style", or "feat"?

@cadojo
Copy link
Collaborator

cadojo commented Dec 31, 2025

Oh also please disregard the CodeCov CI job failure, I'll mark that check optional.

@icweaver icweaver changed the title chore: updates chore: miscellaneous project updates Dec 31, 2025
@icweaver
Copy link
Member Author

icweaver commented Jan 1, 2026

Awesome, happy to. Do you mean to just do a rebase reword on the commit messages? Conventional commits look really useful, thanks for the link!

Where did all of the lints come from? Is that Aqua?

Oh shoot, are you talking about the various whitespace alignments and newlines added? In my attempt to start internalizing some of the guidelines from the various style guides floating around, I do that without thinking sometimes. I can undo those bits if it is distracting to the rest of this PR

@cadojo
Copy link
Collaborator

cadojo commented Jan 4, 2026

No need to rebase any commits! The squash commit message will be the PR title, followed by the PR body. I recommend removing the what's changed header, and changing the bulleted list to match the "keyword: text" syntax for conventional commits. Essentially the PR body will provide "footer" conventional commit messages.

(I can do this myself later today too! I'm on mobile at the moment.)

Thank you as always!

@icweaver
Copy link
Member Author

icweaver commented Jan 4, 2026

Ahh, gotcha. Same, will let you make the changes when you're back, and I'll be sure to use that as a template moving forward 👍🏾

icweaver added a commit that referenced this pull request Jan 7, 2026
@icweaver
Copy link
Member Author

icweaver commented Jan 7, 2026

I took a shot at the conventional commits rewrite in anticipation of potentially getting #277 and #279 in after this PR is merged. Happy to make any edits!

@cadojo
Copy link
Collaborator

cadojo commented Jan 13, 2026

Thank you! Merging this so we can merge #279.

@cadojo cadojo merged commit f5fa23c into main Jan 13, 2026
18 of 19 checks passed
@cadojo cadojo deleted the chore-updates branch January 13, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants