added: inv! for MovingHorizonEstimator covariance matrices#214
Merged
franckgaga merged 3 commits intomainfrom Jun 12, 2025
Merged
added: inv! for MovingHorizonEstimator covariance matrices#214franckgaga merged 3 commits intomainfrom
inv! for MovingHorizonEstimator covariance matrices#214franckgaga merged 3 commits intomainfrom
Conversation
allocation-free with `LinearAlgebra` standard types (and numerically robust since it relies on a cholesky factorization) there is also a fallback method with other `AbstractMatrix` with some allocations
The vector may containt ±Inf value for the MHE and it is not supported by JuMP. The values are updated before optimization anyway.
Member
Author
|
Merging since it passes locally. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 98.92% 98.74% -0.19%
==========================================
Files 26 26
Lines 4286 4306 +20
==========================================
+ Hits 4240 4252 +12
- Misses 46 54 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocation-free methods with
LinearAlgebrastandard types (and numerically robust since it relies on a cholesky factorization, knowing that covariance matrices are positive definite Hermitian matrices).There is also a fallback method with other
AbstractMatrixwith some allocations.Thanks to https://discourse.julialang.org/t/non-allocating-matrix-inversion/62264/14?u=franckgaga for the idea.