Skip to content

Conversation

@serenity4
Copy link
Collaborator

Fixes #633 for version 2.17.

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.17@e65f88f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/interpreter.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             2.17    #634   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      11           
  Lines           ?    1537           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?    1537           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serenity4
Copy link
Collaborator Author

serenity4 commented Apr 11, 2025

Besides the renaming, an additional fix was needed: we relied on the optimizer setting the .inlining_cost field of the source CodeInfo, while with JuliaLang/julia#57979 this operation is more explicit and set only when required during finish!. Because we create the OptimizedSource before finish!, and we rely on its .isinlineable field to be set for src_inlining_policy, it seems we must compute the inlining cost ourselves before hand.

I'll look into whether we really need to hold this information in OptimizedSource, don't merge this just yet.
EDIT: can be merged now and revisited later.

@serenity4 serenity4 merged commit 3df1208 into JuliaDebug:2.17 Apr 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants