Re-enable (and fix) terminal tests#654
Merged
aviatesk merged 9 commits intoJuliaDebug:masterfrom Jul 20, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 12 +3
Lines 1556 1597 +41
======================================
- Misses 1556 1597 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aviatesk
approved these changes
Jul 17, 2025
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
Thanks so much for working on this!
Otherwise, we may hit a hang (a bug occurring after a few toggles are entered), to be diagnosed further
Collaborator
Author
aviatesk
approved these changes
Jul 20, 2025
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
Changes looks great. Thanks for working on this!
timholy
added a commit
that referenced
this pull request
Aug 30, 2025
PR #654 restricted the types allowed to get "through" `treelist!`. While that got the Cthulhu tests working, it broke the intent of the extension API. This restores the original implementation, making changes elsewhere to compensate for the changes in the types of objects that Julia now uses.
timholy
added a commit
that referenced
this pull request
Sep 2, 2025
PR #654 restricted the types allowed to get "through" `treelist!`. While that got the Cthulhu tests working, it broke the intent of the extension API. This restores the original implementation, making changes elsewhere to compensate for the changes in the types of objects that Julia now uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed and refactored tests for
test_terminal.jl, which now all pass except one where it seems that the Revise integration does not work for some reason. I marked it as broken so we can later address it.I'm not sure about enabling/fixing IRShow tests right now, because it seems like they would very easily break by testing against hardcoded IR. I would favor having more precise tests that cover styling (colors etc) as part of the terminal tests, which we can add in the future.