Skip to content

Fix print_response hanging on 1.11.5+ #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 3 commits into from
Apr 18, 2025
Merged

Fix print_response hanging on 1.11.5+ #367

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17c622b
Fix print_response hanging on 1.11.5+
IanButterworth Apr 18, 2025
5585d60
use spawn. add comment
IanButterworth Apr 18, 2025
4e511cb
Update CI.yml
KristofferC Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/repl.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,13 @@ function julia_prompt(state::DebuggerState)
return false
end
command = String(take!(buf))
@static if VERSION >= v"1.2.0-DEV.253"
response = _eval_code(active_frame(state), command)
response = _eval_code(active_frame(state), command)
@static if VERSION >= v"1.11.5"
fetch(@async REPL.print_response(state.repl, response, true, true))
Copy link
Contributor

@oscardssmith oscardssmith Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this isn't using @spawn instead?

Copy link
Contributor Author

@IanButterworth IanButterworth Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason. Did it work like this?

Copy link
Contributor

@oscardssmith oscardssmith Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. It works both with @async and @spawn

Copy link
Contributor Author

@IanButterworth IanButterworth Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Updated. Needs CI to be run, if you have perms.

Copy link
Contributor

@oscardssmith oscardssmith Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. @KristofferC can you run CI?

elseif VERSION >= v"1.2.0-DEV.253"
REPL.print_response(state.repl, response, true, true)
else
ok, result = _eval_code(active_frame(state), command)
ok, result = response
REPL.print_response(state.repl, ok ? result : result[1], ok ? nothing : result[2], true, true)
end
println(state.terminal)
Expand Down