Try to print line ranges in a few more errors #2796
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but this is just a drop in the bucket. There are sooo many more places that could benefit from showing the lines. And is the best we can do really to search the markdown files via a regex? Line ranges should be kept track of during parsing!
Would it seem realistic to either adjust the Markdown stdlib to do that? Just had a quick look at the code, it seems relatively easy to at least keep track of the name of the originating file (if any) plus the position in the file were an node starts/ends (going from there to line ranges shouldn't be hard either). The main counterargument I can think of would be "this would cause overhead in Markdown parsing even for people who don't need it".