Add locrepr methods, improve path generation #2803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has higher level info and thus has an easier time getting paths right.
fingolfin
added
the
Skip Changelog
This was referenced Nov 3, 2025
Member
|
Let's add a brief changelog maybe, since I believe this improves the error messages? Otherwise, LGTM. |
fingolfin
removed
the
Skip Changelog
Collaborator
Author
|
OK, I folded PR #2796 into this one (as it also is about improving error messages) and added a changelog entry. |
mortenpi
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, add a `locrepr(::Document, ::Page) method. This receives higher level info and thus has an easier time getting paths right.
Next, improve that method to ensure the source path is computed correctly relative to the actual document root.
Finally, add a
locrepr(::DCtx)method which ensures we get correct file paths for those as well.Should help with some bad file paths I've seen in some cases, but also with the problem @aaruni96 has been seeing in PR #2793.