Move Windows path warning tests (for path containing :) and actually take their results into account
#2822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back one of the tests removed in #2804 but in a form that's less useless. (See #2804 (comment) for more information about this test.)
However, this will fail CI in the current fork, because the warning (about paths containing
:) is actually different on Windows (were our custom code triggers) versus Unix (where a path with a:is fine, but Documenter will complain because the specified files don't actually exist).So how should we deal with this? Some options:
:to trigger independently of the OStest/docteststests allow different versions of a test based on the Julia version)Thoughts?