Implement interactive 2D dynamical system clicker #252
Conversation
|
The CI failure seems to be unrelated to the change. When trying to run |
| scatterkwargs = (), | ||
| labels = ("x", "y") | ||
| ) | ||
|
|
There was a problem hiding this comment.
Shouldn't you check here that dimension(dds) == 2?
There was a problem hiding this comment.
No, because this function can be used with higher-dimensional dynamical systems, as long as the complete and project parameters are properly defined. Adding such a check would break the use of this in interactive_poincaresos.
docs/src/visualizations.md
Outdated
| @@ -318,3 +318,24 @@ j = 2 # the dimension of the plane | |||
|
|
|||
| interactive_poincaresos_scan(trs, j; linekw = (transparency = true,)) | |||
| ``` | |||
|
|
|||
| ## Interactive projected dynamical system | |||
There was a problem hiding this comment.
Sorry, to be clear: this works for any 2D system, right? This should be 2D maps, projected 2D systems, poincare maps, whatever. Right? If so, do we even need the interactive poincare map function anymore?
Additionally please rename this section to reflect the generality of the function.
There was a problem hiding this comment.
I've updated the docs.
If so, do we even need the interactive poincare map function anymore?
I don't know if we need it, but I think it's pretty useful (and one of the most common use cases, I believe). It would help from a backwards compatibility perspective to preserve the existing interactive_poincaresos API (even though now that function is now a wrapper for this one).
There was a problem hiding this comment.
Hi @GabrielMajeri , sorry that I took so long to return here. I am a bit confused. Is this application for discrete time systems, continuous, or both?
| complete = (x, y) -> [x, y], | ||
| project = identity, |
There was a problem hiding this comment.
Why are these keywords provided here? Shouldn't we expect a ProjectedDynamicalSystem directly instead of allowing the projection to happen within the function?
There was a problem hiding this comment.
Hmm, but then I don't think we could use it directly with PoincareMap?
It should work in principle with any kind of dynamical system, as long as its state space has/can be projected down to two dimensions. I don't actually need this |
Closes #251 by implementing a new
interactive_clickerfunction. It works similar tointeractive_poincaresos, but for an arbitrary 2D dynamical system (e.g.ProjectedDynamicalSystems).