-
Notifications
You must be signed in to change notification settings - Fork 27
Add dimension separator as a type parameter #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add dimension separator as a type parameter #182
Conversation
Pull Request Test Coverage Report for Build 15430506466Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@bjarthur I believe the dimension separator of julia> using Zarr
julia> readdir("ts_test/zarr_v2_raw")
9-element Vector{String}:
".zarray"
"0"
"1"
"2"
"3"
"4"
"5"
"6"
"7"
julia> read("ts_test/zarr_v2_raw/.zarray", String) |> print
{"chunks":[8,8,8],"compressor":null,"dimension_separator":"/","dtype":"<f8","fill_value":null,"filters":null,"order":"C","shape":[64,64,64],"zarr_format":2}
julia> g = zopen("ts_test")
ZarrGroup at DirectoryStore{2, '/'}("ts_test") and path
Variables: zarr_v2_raw
julia> typeof(g)
ZGroup{DirectoryStore{2, '/'}}
julia> arr = g["zarr_v2_raw"]
ZArray{Float64} of size 64 x 64 x 64
julia> typeof(arr)
ZArray{Float64, 3, Zarr.NoCompressor, DirectoryStore{2, '/'}}
julia> arr[1:10,1,1]
10-element Vector{Float64}:
0.5031057549501186
0.30753242290354865
0.7604873102093034
0.3274341519944033
0.016695504839365882
0.4110998920786101
0.2731260969810403
0.5038009325254829
0.1788864699667917
0.8449113642679142 |
This reduces the test diff
This also reduces the test diff
I have prototyped Zarr v3 on top of this and #180 |
The failures on nightly seem to come from CondaPkg not being able to install pixi. |
Currently, I have the following storage wrapper which adds separator and zarr format version information to a storage container. Below the parameters are as follows:
This may be be confused for some kind of storage that keeps track of versions. I am considering renaming this to be
|
Change VersionedStore to FormattedStore
This replaces #150 by implementing the dimension_separator as a type
parameter.
I also intend to add Zarr specification version as a type parameter in forthcoming commits.