inference: propagate more LimitedAccuracy information
#59187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Jameson's comment, we should propagate `LimitedAccuracy` information not only when we actually use the type information of variables that are `LimitedAccuracy`, but also when we perform computations involving variables that are `LimitedAccuracy`. This commit implements that propagation in relation to #59182.
aviatesk
changed the title
LimitedAccuracy information moreLimitedAccuracy information
vtjnash
reviewed
Aug 1, 2025
| function may_form_limited_typ(@nospecialize(aty), @nospecialize(bty), @nospecialize(xty)) | ||
| if aty isa LimitedAccuracy | ||
| if bty isa LimitedAccuracy | ||
| return LimitedAccuracy(xty, union!(copy(aty.causes), bty.causes)) |
There was a problem hiding this comment.
Lgtm. As a followup improvement, note that this actually should be intersect for more accuracy, which we could implement by changing causes to a number (the frame/cycle id) and use min/max on that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Jameson's comment, we should propagate
LimitedAccuracyinformation not only when we actually use the type information of variables that areLimitedAccuracy, but also when we perform computations involving variables that areLimitedAccuracy. This commit implements that propagation in relation to #59182.