Skip to content

inference: propagate more LimitedAccuracy information #59187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2025
Merged

inference: propagate more LimitedAccuracy information #59187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions Compiler/src/typelattice.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,19 @@
# inside the global code cache.
import Core: Const, InterConditional, PartialStruct

function may_form_limited_typ(@nospecialize(aty), @nospecialize(bty), @nospecialize(xty))
if aty isa LimitedAccuracy
if bty isa LimitedAccuracy
return LimitedAccuracy(xty, union!(copy(aty.causes), bty.causes))
Copy link
Member

@vtjnash vtjnash Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. As a followup improvement, note that this actually should be intersect for more accuracy, which we could implement by changing causes to a number (the frame/cycle id) and use min/max on that

else
return LimitedAccuracy(xty, copy(aty.causes))
end
elseif bty isa LimitedAccuracy
return LimitedAccuracy(xty, copy(bty.causes))
end
return nothing
end

"""
cnd::Conditional

Expand Down Expand Up @@ -40,9 +53,8 @@ struct Conditional
isdefined::Bool=false)
assert_nested_slotwrapper(thentype)
assert_nested_slotwrapper(elsetype)
if thentype isa LimitedAccuracy || elsetype isa LimitedAccuracy
return Bool
end
limited = may_form_limited_typ(thentype, elsetype, Bool)
limited !== nothing && return limited
return new(slot, thentype, elsetype, isdefined)
end
end
Expand Down Expand Up @@ -86,9 +98,8 @@ struct MustAlias
assert_nested_slotwrapper(fldtyp)
# @assert !isalreadyconst(vartyp) "vartyp is already const"
# @assert !isalreadyconst(fldtyp) "fldtyp is already const"
if vartyp isa LimitedAccuracy || fldtyp isa LimitedAccuracy
return fldtyp
end
limited = may_form_limited_typ(vartyp, fldtyp, fldtyp)
limited !== nothing && return limited
return new(slot, vartyp, fldidx, fldtyp)
end
end
Expand All @@ -110,9 +121,8 @@ struct InterMustAlias
assert_nested_slotwrapper(fldtyp)
# @assert !isalreadyconst(vartyp) "vartyp is already const"
# @assert !isalreadyconst(fldtyp) "fldtyp is already const"
if vartyp isa LimitedAccuracy || fldtyp isa LimitedAccuracy
return fldtyp
end
limited = may_form_limited_typ(vartyp, fldtyp, fldtyp)
limited !== nothing && return limited
return new(slot, vartyp, fldidx, fldtyp)
end
end
Expand Down