docs: fix crashes on searching documentation of various expressions #59742
+45
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a crash when calling `@doc` on non-document-able expressions such as `:()` so that docs can be returned for the expression itself. Expands `astname` to handle valid expression types explicitly, removes the unused, undocumented `@var` export from Base.Docs, and updates the error message to be clearer. 🤖 Generated with some assistance from Claude Code.
vtjnash
force-pushed
the
jn/doc-errors-less-better
branch
from
db5c7a7 to
4ca97dc
Compare
vtjnash
added
the
needs pkgeval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash when calling
@docon non-document-able expressions so that docs (or lack thereof) can be successfully printed. For example, looking up docs on sad faces, doesn't crash and cause sad faces after this change:Details: expands
astnameto handle valid expression types explicitly, removes the unused, undocumented@varexport from Base.Docs, and updates the error message to be clearer.🤖 Generated with some assistance from Claude Code.